Allow for using python -m pyjs_code_runner.cli#10
Draft
jtpio wants to merge 1 commit intoemscripten-forge:mainfrom
Draft
Allow for using python -m pyjs_code_runner.cli#10jtpio wants to merge 1 commit intoemscripten-forge:mainfrom
python -m pyjs_code_runner.cli#10jtpio wants to merge 1 commit intoemscripten-forge:mainfrom
Conversation
Member
Author
|
Will probably be better to get #8 in first before undrafting. |
DerThorsten
reviewed
Apr 24, 2023
Collaborator
There was a problem hiding this comment.
@jtpio
this wont work as we do this in the main.py:
from .run import * # noqa: F401, F403
from .version import * # noqa: F401, F403
https://github.com/emscripten-forge/pyjs-code-runner/blob/main/pyjs_code_runner/cli/main.py#L1-L3
This imports / registers the commands to the cli, ie if we take the app directly from app.py we are not registering any command)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow for invoking the tool with
python -m pyjs_code_runner.cli`, which is also common for running Python applications.